firstItemPosition computed property is not recomputed when sortedItems changes
#600
+232
−52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ember-sortable canceled.
|
|
I'd feel more comfortable if this PR provided a test that failed before the changes here, and then passes afterwards <3 |
|
The changes to the test app feel a smidge excessive? Why'd every example have to change? Can something more targeted happen instead? |
|
Also, biggest apologies for not commenting sooner. I don't know how i missed this PR <3 |
gwak
force-pushed
the
fix/non-refreshed-computed-property
branch
from
3160b76 to
27a34c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes a fix for the test case highlighted in the PR #599.
The changes removes the computed property on the
firstItemPositiongetter insortable-group.tsmodifier as it's not recomputed when thesortedItemsarray changes from the outside. If excessive recomputation of that getter gets expensive we could maybe use the more modern@cacheddecorator from@glimmer/tracking?