Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enabling Renassiance graph #889

Merged
merged 2 commits into from
Jul 9, 2024
Merged

Re-enabling Renassiance graph #889

merged 2 commits into from
Jul 9, 2024

Conversation

Sangyoon21
Copy link
Contributor

@Sangyoon21 Sangyoon21 commented Jul 9, 2024 •
edited
Loading

Fixes Issue #874. We made following improvements:

  • Use length instead of size to check for valid values array
  • Convert time into epochs to be sorted arithmetically by mathjs/sort
  • Display the series with the correct format

Done with @tpbui

@netlify Netlify
Copy link

netlify bot commented Jul 9, 2024 •
edited
Loading

✅ Deploy Preview for eclipsefdn-adoptium-trss ready!

Name Link
🔨 Latest commit 4d21641
🔍 Latest deploy log https://app.netlify.com/sites/eclipsefdn-adoptium-trss/deploys/668d4a2cf23fdd00084ab07b
😎 Deploy Preview https://deploy-preview-889--eclipsefdn-adoptium-trss.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Sangyoon21 Sangyoon21 changed the title We made the Renassiance graph working Renassiance graph working Jul 9, 2024
@Sangyoon21 Sangyoon21 changed the title Renassiance graph working Re-enabling Renassiance graph Jul 9, 2024
@Sangyoon21
Update Renaissance.jsx
4d21641 
We made some style changes and made the code more clear.
@Sangyoon21 Sangyoon21 marked this pull request as ready for review July 9, 2024 14:35
smlambert
smlambert approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smlambert smlambert merged commit 17ae977 into adoptium:master Jul 9, 2024
7 checks passed
@Sangyoon21 Sangyoon21 deleted the graph_v1 branch July 9, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smlambert smlambert smlambert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sangyoon21 @smlambert