Pull jdkVersion from parent if not in child name #956
Merged
+16
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shelley Lambert <[email protected]>
✅ Deploy Preview for eclipsefdn-adoptium-trss ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Shelley Lambert <[email protected]>
Signed-off-by: Shelley Lambert <[email protected]>
|
Preview shows this approach works for JDK25(tip) |
|
Apparently I could merge my own PR without a review in this repo now, which is undesirable and seems to be a regression in permissions. 
I am on vacation, so won't fix otterdog permissions until back (unless someone fixes it before me). |
llxia
reviewed
Dec 17, 2024
Signed-off-by: Shelley Lambert <[email protected]>
|
Updated based on review suggestions |
|
re #956 (comment), issue opened at #957 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #816
Other wrapper scripts / parent jobs (such as AQA_Test_Pipeline) do not run builds, they only run test jobs which always have the version number in the child jobs, so this approach should cover our cases. This will work for the standard naming used in ci-jenkins-pipelines top-level jobs.