-
-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CryptoTests_jtreg #5240
Add CryptoTests_jtreg #5240
Conversation
e673e88
to
fc7d768
Compare
|
- add CryptoTests_jtreg back (based on the original change https://github.com/adoptium/aqa-tests/pull/5134/files) - CryptoTests_jtreg directly triggers the tests via jtreg and it runs against all vendors except redhat - CryptoTests only runs for vendor=redhat - re-enable CryptoTests_jtreg on aarch64_mac|x86-64_mac|s390x_linux (related to run.sh issue. See CryptoTests readlink: illegal option -- f eclipse-openj9/openj9#19164) - add retry for git clone to mitigate network issue - add check CryptoTest repo sha (sha will be captured in TAP file) Signed-off-by: Lan Xia <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @llxia !
@@ -49,5 +49,47 @@ | |||
<groups> | |||
<group>functional</group> | |||
</groups> | |||
<vendors> | |||
<vendor>redhat</vendor> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be make opposite? To enable this main for all, except the few broken, and enable CryptoTests_jtreg only for the zOs or whereevere the main rnner do not fit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be make opposite? To enable this main for all, except the few broken, and enable CryptoTests_jtreg only for the zOs or whereevere the main rnner do not fit?
If this PR would have not moved the default exclusion in favour of itself it would be awesome temporary workaround for affected platforms before the real issue s fixed.
To merging this without actually waiting for any input from original authors is really weird. |
You provided your input @judovana. You said you need and want the run.sh wrapper for the way you run your Jenkins jobs, so you have a test target CryptoTest. For all others who currently do not want the extra runner (or gain benefit from it) and who have been running this test material without it and are happy to do so get a test target called CryptoTest_jtreg. Everyone gets to run the test material in the way they want and the committers do not have to keep milling around this topic when there are hundreds of other topics to attend to. The test material is invoked and running. This is the important aspect, that the tests are re-enabled and running. |
related: #5206