Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openjdk: langtools_all target #5353

Merged
merged 2 commits into from
Jun 3, 2024
Merged

Conversation

zzambers
Copy link
Contributor

@zzambers zzambers commented May 29, 2024

This adds langtools_all target to openjdk to run langtools tests (see: #5318).

Testing:
x86-64_linux:
jdk 21: OK
jdk 17: OK
jdk 11: OK
jdk 8: OK

x86-64_windows
jdk 21: OK
jdk 8: FAILED (infra issue?, rerun OK)

x86-64_mac
jdk 21: OK
jdk 8: OK

@llxia
Copy link
Contributor

llxia commented May 30, 2024

I do not think langtools is fully enabled in openj9/ibm. Please run the Grinder to ensure this test is valid for openj9.

@sophia-guo sophia-guo self-requested a review May 30, 2024 15:00
@sophia-guo
Copy link
Contributor

@llxia could you please point the openj9/ibm SDK URL ?

@zzambers
Copy link
Contributor Author

zzambers commented Jun 3, 2024

I have tried openj9 using example urls as CUSTOMIZED_SDK_URL. I see some failures:

x86-64_linux / jdk8 / openj9: FAILURES
ppc64le_linux / jdk17 / openj9: FAILURES

this is interesting, I would not expect that using different jvm, should make difference here (javac, javadoc), but obviously it does.

@zzambers
Copy link
Contributor Author

zzambers commented Jun 3, 2024

I can make langtools_all hotspot only for now.

@llxia
Copy link
Contributor

llxia commented Jun 3, 2024

@pshipton could you please confirm that we should exclude langtools tests for openj9/ibm? If so, do we have an openj9 issue for reference in the disabled comment? Thanks

@pshipton
Copy link
Contributor

pshipton commented Jun 3, 2024

Created eclipse-openj9/openj9#19605

@llxia
Copy link
Contributor

llxia commented Jun 3, 2024

@zzambers please disable langtools_all target for both impl openj9 and ibm and reference eclipse-openj9/openj9#19605 in the disable comment. Thanks

Copy link
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zzambers

@llxia llxia merged commit 770ec32 into adoptium:master Jun 3, 2024
2 checks passed
@zzambers
Copy link
Contributor Author

zzambers commented Jun 3, 2024

@llxia thanks

btw. I have tried to rerun openj9 jobs, verified, that openj9 failures are reproducible in grinder:
https://ci.adoptium.net/view/Test_grinder/job/Grinder/10149/
https://ci.adoptium.net/view/Test_grinder/job/Grinder/10150/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants