Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude 2 ipv6 jdk8 tests on linux-all for Adoptium #5402

Merged
merged 2 commits into from
Jun 28, 2024

Conversation

Haroon-Khel
Copy link
Contributor

@Haroon-Khel Haroon-Khel commented Jun 24, 2024

Both tests are failing consistently on JDK8 linux platforms, adoptium/infrastructure#3614.

Copy link
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as we had done this for mac, but this is quite specific to our Adoptium infrastructure not having IPv6 enabled, so perhaps we should have these excludes in a vendor/adoptium excludes folder, instead of excluding testcases for all vendors.

@Haroon-Khel
Copy link
Contributor Author

Haroon-Khel commented Jun 28, 2024

Approving as we had done this for mac, but this is quite specific to our Adoptium infrastructure not having IPv6 enabled, so perhaps we should have these excludes in a vendor/adoptium excludes folder, instead of excluding testcases for all vendors.

I didn't realise that was an option, that's a better idea. I've changed the pr accordingly

@Haroon-Khel Haroon-Khel changed the title Exclude 2 ipv6 jdk8 tests on linux-all Exclude 2 ipv6 jdk8 tests on linux-all for Adoptium Jun 28, 2024
@Haroon-Khel
Copy link
Contributor Author

I dont have write access so I can't merge this despite the 2 approvals

@sophia-guo sophia-guo merged commit 7dab31e into adoptium:master Jun 28, 2024
2 checks passed
@sophia-guo
Copy link
Contributor

@Haroon-Khel I didn't realize that you have updated to vendor/adoptium folder and merged. I don't think currently we support adoptium vendor yet

@sophia-guo
Copy link
Contributor

Checked TKG, for now If System.getProperty('java.vendor')=Eclipse Adoptium jdk_vendor is set as eclipse. Could we use /vendor/eclipse @smlambert ? If yes @Haroon-Khel we need to update https://github.com/adoptium/aqa-tests/blob/master/openjdk/openjdk.mk#L238 to include eclipse

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants