Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set RERUN_FAILURE flag to false in Grinder #5859

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Set RERUN_FAILURE flag to false in Grinder #5859

merged 1 commit into from
Jan 16, 2025

Conversation

dennycjacob
Copy link
Contributor

@dennycjacob dennycjacob commented Jan 15, 2025 •
edited
Loading

Set RERUN_FAILURE flag to false

fixes : #5856
Signed-off-by: Denny Chacko Jacob[email protected]

@dennycjacob dennycjacob reopened this Jan 15, 2025
@dennycjacob dennycjacob force-pushed the RERUN_FAILURE_flag branch 2 times, most recently from ce2c91f to bd90b09 Compare January 15, 2025 15:15
@llxia
Copy link
Contributor

llxia commented Jan 15, 2025

Thanks @dennycjacob . Please read https://github.com/adoptium/aqa-tests/blob/master/Contributing.md for commit message expectations.

@dennycjacob dennycjacob changed the title Setting RERUN_FAILURE flag to false in Grinder Set RERUN_FAILURE flag to false in Grinder Jan 15, 2025
@karianna karianna requested a review from llxia January 15, 2025 20:58
@dennycjacob
Copy link
Contributor Author

Grinder Test:
RERUN FLAG = true on initial Run
https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/46607/
RERUN_FLAG is not visible on clicking Rerun in Grinder Link

@llxia
Copy link
Contributor

llxia commented Jan 16, 2025 •
edited
Loading

@dennycjacob could you remove adoptium/aqa-tests in between fixes : adoptium/aqa-tests #5856 in the PR description? Please also keep the commit message in sync. i.e., instead of related, fixes should be used.

Move the PR out of the draft once this is ready for review. Thanks

@dennycjacob
Setting RERUN_FAILURE flag to false in Grinder
22935fb 
- RERUN_FAILURE flag to false
fixes : adoptium#5856
Signed-off-by: Denny Chacko Jacob<[email protected]>
@dennycjacob dennycjacob marked this pull request as ready for review January 16, 2025 19:08
llxia
llxia approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@llxia llxia requested a review from JasonFengJ9 January 16, 2025 20:49
@JasonFengJ9 JasonFengJ9 merged commit b070986 into adoptium:master Jan 16, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@llxia llxia llxia approved these changes

@JasonFengJ9 JasonFengJ9 JasonFengJ9 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RERUN_FAILURE should set to false in Grinder
3 participants
@dennycjacob @llxia @JasonFengJ9