Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable tools/jpackage/share disabled by jdk_tools for non jdk17 #5891

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

sophia-guo
Copy link
Contributor

@sophia-guo sophia-guo commented Jan 21, 2025

Exclude one failing test with alpine by linux-all under adoptium. So test is only excluded for adoptium on other linux platforms including alpine.

Close #3232

See tools/jpackage/share
related #5892
#5893
#5894

Exclude one failing test with alpine by linux-all under adoptium. So
test is only excluded for adoptium on other linux platforms including
alpine.

Signed-off-by: Sophia Guo <[email protected]>
@sophia-guo sophia-guo self-assigned this Jan 21, 2025
@sophia-guo sophia-guo requested a review from smlambert January 21, 2025 21:38
@sophia-guo
Copy link
Contributor Author

Will not cherry-pick this for January's release. Need more runs before add to release.

@sophia-guo sophia-guo marked this pull request as draft January 21, 2025 21:45
@sophia-guo sophia-guo marked this pull request as ready for review January 22, 2025 03:18
Signed-off-by: Sophia Guo <[email protected]>
Copy link
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How many testcases does this end up excluding (how many are in jdk_tools target)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Failing openjdk17 alpine-linux jdk_tools tests
2 participants