Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable the reproduce_compare jobs now aqa-test Rebuild_Same_JDK_Reproducibility_Test_0 running #1093

Merged
merged 7 commits into from
Sep 4, 2024

Conversation

andrew-m-leonard
Copy link
Contributor

@andrew-m-leonard andrew-m-leonard commented Aug 8, 2024

Fixes #1092

Disable ENABLE_REPRODUCIBLE_COMPARE by default, now we have Rebuild_Same_JDK_Reproducibility_Test_0 in aqa-tests.

Also fix the base pipeline groovy to correctly honour the "Enable Reproduce Compare" option, which mean if enabled for the given platform then enable for that build job... (hence why param description says "might run...")

Copy link

github-actions bot commented Aug 8, 2024

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.
To run full set of tests, use "run tests"; a subset of tests on specific jdk version, use "run tests quick 11,21"

@andrew-m-leonard andrew-m-leonard changed the title Disable the old Disable the reproduce_compare jobs now aqa-test Rebuild_Same_JDK_Reproducibility_Test_0 running Aug 8, 2024
@andrew-m-leonard andrew-m-leonard self-assigned this Aug 8, 2024
@andrew-m-leonard
Copy link
Contributor Author

run tests

@eclipse-temurin-bot
Copy link
Collaborator

 PR TESTER RESULT 

❎ Some pipelines failed or the job was aborted! ❎
See the pipeline-build-check below for more information...

@andrew-m-leonard
Copy link
Contributor Author

run tests

@eclipse-temurin-bot
Copy link
Collaborator

 PR TESTER RESULT 

✅ All pipelines passed! ✅

@andrew-m-leonard andrew-m-leonard enabled auto-merge (squash) August 9, 2024 14:55
@andrew-m-leonard
Copy link
Contributor Author

run tests

@eclipse-temurin-bot
Copy link
Collaborator

 PR TESTER RESULT 

❎ Some pipelines failed or the job was aborted! ❎
See the pipeline-build-check below for more information...

@andrew-m-leonard
Copy link
Contributor Author

run tests

@eclipse-temurin-bot
Copy link
Collaborator

 PR TESTER RESULT 

❎ Some pipelines failed or the job was aborted! ❎
See the pipeline-build-check below for more information...

@andrew-m-leonard
Copy link
Contributor Author

Only failure is jdk8u Alpine, which we know has an upstream build break.

@andrew-m-leonard
Copy link
Contributor Author

@sophia-guo should be good now

@andrew-m-leonard andrew-m-leonard merged commit 4bfdbb6 into adoptium:master Sep 4, 2024
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

disable build job default for ENABLE_REPRODUCIBLE_COMPARE
4 participants