-
-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update workspace when running in windows containers #1101
Conversation
Signed-off-by: Stewart X Addison <[email protected]>
run tests |
Thank you for creating a pull request!Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work). Code Quality and Contributing GuidelinesIf you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before. TestsGithub actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation. In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post |
This was copied from the non-docker case but I don't believe it's part of the same logic, so skipping for simplicity Signed-off-by: Stewart X Addison <[email protected]>
PR TESTER RESULT ❎ Some pipelines failed or the job was aborted! ❎ |
run tests |
Noting that I've been using this for a few days now without any problems, so the logic appears to be safe and reliable. |
The initial pr test pipeline failed on jdk11u with this which should have nothing to do with this PR:
The jdk11u ea triggered pipeline from yesterday built ok, so we shall see if there is any failure in the new pipeline triggered by the |
PR TESTER RESULT ✅ All pipelines passed! ✅ |
195 is good so the failure with JDK11u in 194 seems to have been a transient bug, potentially in the upstream build. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
Continuation of the first phase in #1099
Resolves adoptium/infrastructure#3710
Part of adoptium/infrastructure#3286
The solution here is a copy of the logic in the non-docker case. Noting that I have not adjusted the logic for the case where a Dockerfile is supplied. That is not used currently functionality which we use at Temurin so I don't want to encourage anyone :-)
Saving pipeline link here