Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update workspace when running in windows containers #1101

Merged
merged 2 commits into from
Sep 2, 2024

Conversation

sxa
Copy link
Member

@sxa sxa commented Aug 22, 2024

Continuation of the first phase in #1099
Resolves adoptium/infrastructure#3710
Part of adoptium/infrastructure#3286

The solution here is a copy of the logic in the non-docker case. Noting that I have not adjusted the logic for the case where a Dockerfile is supplied. That is not used currently functionality which we use at Temurin so I don't want to encourage anyone :-)

Saving pipeline link here

@sxa
Copy link
Member Author

sxa commented Aug 22, 2024

run tests

Copy link

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.
To run full set of tests, use "run tests"; a subset of tests on specific jdk version, use "run tests quick 11,21"

This was copied from the non-docker case but I don't believe it's part of the same logic, so skipping for simplicity

Signed-off-by: Stewart X Addison <[email protected]>
@eclipse-temurin-bot
Copy link
Collaborator

 PR TESTER RESULT 

❎ Some pipelines failed or the job was aborted! ❎
See the pipeline-build-check below for more information...

@sxa
Copy link
Member Author

sxa commented Aug 29, 2024

run tests

@sxa
Copy link
Member Author

sxa commented Aug 29, 2024

Noting that I've been using this for a few days now without any problems, so the logic appears to be safe and reliable.

@sxa
Copy link
Member Author

sxa commented Aug 29, 2024

The initial pr test pipeline failed on jdk11u with this which should have nothing to do with this PR:

18:20:07  Compiling 3 files for BUILD_DEMO_FileChooserDemo
18:20:09  Updating support/demos/image/jfc/FileChooserDemo/src.zip
18:20:10  Note: c:\workspace\openjdk-build\workspace\build\src\src\demo\share\jfc\FileChooserDemo\FileChooserDemo.java uses or overrides a deprecated API.
18:20:10  Note: Recompile with -Xlint:deprecation for details.
18:20:10  Note: c:\workspace\openjdk-build\workspace\build\src\src\demo\share\jfc\FileChooserDemo\FileChooserDemo.java uses unchecked or unsafe operations.
18:20:10  Note: Recompile with -Xlint:unchecked for details.
18:20:10  make[3]: *** [CompileDemos.gmk:177: /cygdrive/c/workspace/openjdk-build/workspace/build/src/build/windows-x86_64-normal-clientandserver-release/support/demos/classes/jfc/FileChooserDemo/_the.BUILD_DEMO_FileChooserDemo_batch] Error 1
18:20:10  make[3]: *** Waiting for unfinished jobs....
18:20:10  make[2]: *** [make/Main.gmk:330: demos-jdk] Error 2
18:20:10  make[2]: *** Waiting for unfinished jobs....

The jdk11u ea triggered pipeline from yesterday built ok, so we shall see if there is any failure in the new pipeline triggered by the run tests command today https://ci.adoptium.net/job/build-scripts-pr-tester/job/openjdk-build-pr-tester/1914/ (Should trigger jdk11 windows pipeline 195)

@sxa sxa requested a review from smlambert August 29, 2024 12:40
@eclipse-temurin-bot
Copy link
Collaborator

 PR TESTER RESULT 

✅ All pipelines passed! ✅

@sxa
Copy link
Member Author

sxa commented Aug 29, 2024

(Should trigger jdk11 windows pipeline 195)

195 is good so the failure with JDK11u in 194 seems to have been a transient bug, potentially in the upstream build.

@sxa sxa requested a review from andrew-m-leonard September 2, 2024 12:44
Copy link
Contributor

@andrew-m-leonard andrew-m-leonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@sxa sxa merged commit d33d46f into adoptium:master Sep 2, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

windocker: Figure out how to use longer (original) names for the pipelines
4 participants