-
-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable RERUN_FAILURE for AQA test builds #1178
Conversation
resolves: adoptium#1177 Signed-off-by: Lan Xia <[email protected]>
Thank you for creating a pull request!Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work). Code Quality and Contributing GuidelinesIf you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before. TestsGithub actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation. In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post |
@smlambert could you please review? Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Lan! This LGTM in terms of AQAvit test runs. We remotely trigger for JCK testing, so not sure if we want to trial this for those jobs, but that would need a second line somewhere after L637. (Perhaps we trial it first on the public server and update later for the private server).
This PR only enables RERUN_FAILURE for AQA test builds. Since Adoptium uses another top-level job
AQA_Test_Pipeline job config. I would prefer to set RERUN_FAILURE to true as default via AQA_Test_Pipeline job config. This is to avoid any confusion in the future if AQA_Test_Pipeline is launched alone.
However, If you prefer to set in the pipeline code, please let me know. I will update the PR to cover in |
Indeed, I think its best to set it in the job config on the server in question (which I will do) rather than passed in as a parameter. Thanks! |
resolves: adoptium#1177 Signed-off-by: Lan Xia <[email protected]>
resolves: #1177 Signed-off-by: Lan Xia <[email protected]>
resolves: #1177