Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable RERUN_FAILURE for AQA test builds #1178

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

llxia
Copy link
Contributor

@llxia llxia commented Jan 8, 2025

resolves: #1177

Copy link

github-actions bot commented Jan 8, 2025

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.
To run full set of tests, use "run tests"; a subset of tests on specific jdk version, use "run tests quick 11,21"

@llxia
Copy link
Contributor Author

llxia commented Jan 8, 2025

@smlambert could you please review? Thanks

Copy link
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Lan! This LGTM in terms of AQAvit test runs. We remotely trigger for JCK testing, so not sure if we want to trial this for those jobs, but that would need a second line somewhere after L637. (Perhaps we trial it first on the public server and update later for the private server).

@smlambert smlambert requested a review from sophia-guo January 8, 2025 17:01
@llxia
Copy link
Contributor Author

llxia commented Jan 8, 2025

This PR only enables RERUN_FAILURE for AQA test builds. Since Adoptium uses another top-level job AQA_Test_Pipeline for JCK, RERUN_FAILURE should be set again. It can be set within

def remoteTriggerJckTests(String platform, String jdkFileName) {
or just set in AQA_Test_Pipeline job config. I would prefer to set RERUN_FAILURE to true as default via AQA_Test_Pipeline job config. This is to avoid any confusion in the future if AQA_Test_Pipeline is launched alone.

However, If you prefer to set in the pipeline code, please let me know. I will update the PR to cover in remoteTriggerJckTests().

@smlambert
Copy link
Contributor

smlambert commented Jan 8, 2025

just set in AQA_Test_Pipeline job config. I would prefer to set RERUN_FAILURE to true as default via AQA_Test_Pipeline job config. This is to avoid any confusion in the future if AQA_Test_Pipeline is launched alone.
However, If you prefer to set in the pipeline code, please let me know. I will update the PR to cover in remoteTriggerJckTests().

Indeed, I think its best to set it in the job config on the server in question (which I will do) rather than passed in as a parameter. Thanks!

@smlambert smlambert removed the request for review from sophia-guo January 8, 2025 17:38
@smlambert smlambert merged commit 82afcc4 into adoptium:master Jan 8, 2025
9 checks passed
llxia added a commit to llxia/ci-jenkins-pipelines that referenced this pull request Jan 8, 2025
karianna pushed a commit that referenced this pull request Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable the auto-rerun for Test jobs with FAILURE status
3 participants