Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo fixes in prTester readme file #479

Merged
merged 3 commits into from
Mar 11, 2024
Merged

Typo fixes in prTester readme file #479

merged 3 commits into from
Mar 11, 2024

Conversation

AyBims
Copy link
Contributor

@AyBims AyBims commented Oct 17, 2022

Fixes: #454
signed-off-by: Ayomide Adeshina [email protected]

@github-actions
Copy link

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.
To run full set of tests, use "run tests"; a subset of tests on specific jdk version, use "run tests quick 11,19"

Copy link
Contributor

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zdtsw
Copy link
Contributor

zdtsw commented Nov 8, 2022

some linter errors still need to fix

@karianna
Copy link
Contributor

karianna commented Nov 8, 2022

@AyBims - A few linter issues to fix as Wen mentions.

@karianna
Copy link
Contributor

@AyBims Are you able to rebase this PR?

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A block has been put on this Pull Request as this repository is temporarily under a code freeze due to an ongoing release cycle.

If this pull request needs to be merged during the release cycle then please comment /merge and a PMC member will be able to remove the block.

If the code freeze is over you can remove this block by commenting /thaw.

@gdams
Copy link
Member

gdams commented Mar 11, 2024

/thaw

@github-actions github-actions bot dismissed their stale review March 11, 2024 16:04

Pull Request unblocked - code freeze is over.

@gdams gdams merged commit 3a810d5 into adoptium:master Mar 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typo: the prTester readme has one typo
4 participants