Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for . in beta binaries status check of archive EA filename #921

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

andrew-m-leonard
Copy link
Contributor

New beta EA filename has "." in the version part of the filename, the nightly_build_and_test_stats.groovy regex needs updating to match it correctly.

Copy link

github-actions bot commented Feb 9, 2024

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.
To run full set of tests, use "run tests"; a subset of tests on specific jdk version, use "run tests quick 11,21"

@github-actions github-actions bot added code-tools Issues that are miscellaneous enhancements or bugs with our utilities that assist our build scripts testing labels Feb 9, 2024
@andrew-m-leonard andrew-m-leonard changed the title Allow for . in nightly archive EA filename Allow for . in beta binaries status check of archive EA filename Feb 9, 2024
@andrew-m-leonard andrew-m-leonard self-assigned this Feb 9, 2024
@andrew-m-leonard andrew-m-leonard requested a review from sxa February 9, 2024 19:51
Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit nervous as to why \. was in there in the first place in case this breaks something, but I guess it's easily fixable if it causes a problem so I'm approving.

Noting that the old versions had a name like this:

And the new one is:

See adoptium/temurin-build#3355 (comment) for the reasons why it was done with hyphens originally - it was to do the minimal amount of work needed to avoid changing the existing release tool job.

@andrew-m-leonard
Copy link
Contributor Author

I'm a bit nervous as to why \. was in there in the first place in case this breaks something, but I guess it's easily fixable if it causes a problem so I'm approving.

Noting that the old versions had a name like this:

* [OpenJDK21U-jdk_aarch64_linux_hotspot_ea_21-0-1-12.tar.gz](https://github.com/adoptium/temurin21-binaries/releases/download/jdk-21.0.1%2B12-ea-beta/OpenJDK21U-jdk_aarch64_linux_hotspot_ea_21-0-1-12.tar.gz)

And the new one is:

* [OpenJDK21U-jdk_aarch64_linux_hotspot_ea_21.0.3-0-1.tar.gz](https://github.com/adoptium/temurin21-binaries/releases/download/jdk-21.0.3%2B1-ea-beta/OpenJDK21U-jdk_aarch64_linux_hotspot_ea_21.0.3-0-1.tar.gz)

See adoptium/temurin-build#3355 (comment) for the reasons why it was done with hyphens originally - it was to do the minimal amount of work needed to avoid changing the existing release tool job.

I think basically I over did it last time !

@andrew-m-leonard andrew-m-leonard merged commit 6df3828 into adoptium:master Feb 12, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-tools Issues that are miscellaneous enhancements or bugs with our utilities that assist our build scripts testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants