Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inventory: Update test-ibmcloud-ubuntu1604-x64-1 IP #1848

Merged
merged 1 commit into from
Jan 18, 2021
Merged

inventory: Update test-ibmcloud-ubuntu1604-x64-1 IP #1848

merged 1 commit into from
Jan 18, 2021

Conversation

Willsparker
Copy link
Contributor

ref: #1716

Spotted by @sxa when I wasn't able to ssh to it, despite my key being on the machine.

  • commit message has one of the standard prefixes
  • inventory changes, ensure bastillion is updated accordingly

@Willsparker Willsparker added this to the January 2021 milestone Jan 18, 2021
@Willsparker Willsparker requested a review from sxa January 18, 2021 11:42
@Willsparker Willsparker self-assigned this Jan 18, 2021
sxa
sxa requested changes Jan 18, 2021
View reviewed changes
Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, can you changet he prefix on the commit message to be inventory: instead of inv: please?

@Willsparker Willsparker changed the title inv: Update test-ibmcloud-ubuntu1604-x64-1 IP inventory: Update test-ibmcloud-ubuntu1604-x64-1 IP Jan 18, 2021
@Willsparker
Copy link
Contributor Author

Fixed :-)

sxa
sxa approved these changes Jan 18, 2021
View reviewed changes
Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know where that Solaris VPC error has come from but this PR clearly has nothing to do with it so approving and merging

@sxa sxa merged commit 78b8c8d into adoptium:master Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sxa sxa sxa approved these changes

Assignees

@Willsparker Willsparker

Labels
provider:ibmcloud
Projects
None yet
Milestone
January 2021
Development

Successfully merging this pull request may close these issues.
2 participants
@Willsparker @sxa