Skip to content

Commit

Permalink
Update comment
Browse files Browse the repository at this point in the history
Co-authored-by: Severin Gehwolf <[email protected]>
  • Loading branch information
andrew-m-leonard and jerboaa authored Dec 11, 2024
1 parent e194ae3 commit b90d202
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion sign.sh
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,11 @@ signRelease()
# Sign all files with the executable permission bit set.

if [ "$SIGN_TOOL" = "eclipse" ] && [ "${VERSION}" != "8" ]; then
# Eclipse jdk-11+ post-build signing should only sign the libjli.dylib bundle executable, as there rest are already internally signed in the build
# On MacOSX, libjli.dylib is copied in two places. Once in Contents/home/lib/libjli.dylib and once in
# Contents/MacOS/libjli.dylib. The latter is the bundle executable entry-point and hasn't been signed by
# by the build in contrast to content in Contents/home. Therefore, Eclipse jdk-11+ post-build signing should
# only sign the libjli.dylib bundle executable in Contents/MacOS, as there rest are already internally signed
# in the build
FILES=$(find . -name 'libjli.dylib' | grep 'Contents/MacOS' || true)
else
FILES=$(find "${TMP_DIR}" -perm +111 -type f -not -name '.*' -o -name '*.dylib' || find "${TMP_DIR}" -perm /111 -type f -not -name '.*' -o -name '*.dylib')
Expand Down

0 comments on commit b90d202

Please sign in to comment.