Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jdk8u Windows sign_verification failing: api-ms* should not be signed by Eclipse.org as it is already signed by Microsoft #4111

Closed
andrew-m-leonard opened this issue Jan 8, 2025 · 0 comments · Fixed by #4112
Closed

jdk8u Windows sign_verification failing: api-ms* should not be signed by Eclipse.org as it is already signed by Microsoft #4111

andrew-m-leonard opened this issue Jan 8, 2025 · 0 comments · Fixed by #4112
Assignees
@andrew-m-leonard
Labels
buildbreak High priority issues that cause build breaks in jenkins or build scripts

Comments

@andrew-m-leonard
Copy link
Contributor

sign_verification now verifies we don't sign Microsoft supplied Redist DLLs twice with an additional Eclipse signature, but sign.sh used to sign jdk8u has not been updated to skip these files.
https://ci.adoptium.net/job/build-scripts/job/release/job/sign_verification/2280/consoleFull

Error: unpacked/jdk/jdk8u442-b05/bin/api-ms-win-core-console-l1-1-0.dll should not be signed by Eclipse.org as it is already signed by Microsoft.
@andrew-m-leonard andrew-m-leonard added the buildbreak High priority issues that cause build breaks in jenkins or build scripts label Jan 8, 2025
@andrew-m-leonard andrew-m-leonard self-assigned this Jan 8, 2025
@andrew-m-leonard andrew-m-leonard moved this to In Progress in 2025 Adoptium Plan Jan 8, 2025
@andrew-m-leonard andrew-m-leonard mentioned this issue Jan 8, 2025
Merged
@github-project-automation github-project-automation bot moved this from In Progress to Done in 2025 Adoptium Plan Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrew-m-leonard andrew-m-leonard

Labels
buildbreak High priority issues that cause build breaks in jenkins or build scripts
Projects
2025 Adoptium Plan
Status: Done
Milestone
No milestone
1 participant
@andrew-m-leonard