Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jdk8u sign.sh Eclipse signing to not sign apims Microsoft files #4112

Merged

Conversation

andrew-m-leonard
Copy link
Contributor

@andrew-m-leonard andrew-m-leonard commented Jan 8, 2025

Fixes #4111

Update jdk8u signing script sign.sh to skip Microsoft Redist DLLs

Test build: https://ci.adoptium.net/job/build-scripts/job/jobs/job/jdk8u/job/jdk8u-windows-x64-temurin/545/ - SUCCESS

@github-actions github-actions bot added the installer Issues that relate to our installer jobs or installer repo label Jan 8, 2025
@andrew-m-leonard andrew-m-leonard self-assigned this Jan 8, 2025
Copy link
Contributor

@steelhead31 steelhead31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link
Contributor

@Haroon-Khel Haroon-Khel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving on the basis that youve tested it and it works. Needs to be cherry picked into v2025.01.01

@andrew-m-leonard andrew-m-leonard merged commit 7331a24 into adoptium:master Jan 8, 2025
27 checks passed
andrew-m-leonard added a commit to andrew-m-leonard/openjdk-build that referenced this pull request Jan 8, 2025
Haroon-Khel pushed a commit that referenced this pull request Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
installer Issues that relate to our installer jobs or installer repo
Projects
None yet
3 participants