Ensure GPG temp dir can be created for long build folder paths on linux riscv64

[andrew-m-leonard]

Fixes #3659

linux riscv64 GPG has folder path length limitations, similar to Alpine.

Successful GPG creation test: https://ci.adoptium.net/job/build-scripts/job/jobs/job/evaluation/job/jobs/job/jdk21u/job/jdk21u-evaluation-linux-riscv64-temurin/142/

[sxa]

Is there a reason this needs to be an elif instead of adding it the section that detects Alpine? This feels like unnecessary duplication

[andrew-m-leonard]

Is there a reason this needs to be an elif instead of adding it the section that detects Alpine? This feels like unnecessary duplication

Not sure this complex if works in bash would it? hence I took the less elegant but works approach

if [[ -r /etc/alpine-release ] || [[ "${BUILD_CONFIG[OS_KERNEL_NAME]}" == "linux" ] && [ "${BUILD_CONFIG[OS_ARCHITECTURE]}" == "riscv64" ]] ] && [ "$(pwd | wc -c)" -gt 83 ]; then

[sxa]

Is there a reason this needs to be an elif instead of adding it the section that detects Alpine? This feels like unnecessary duplication

Not sure this complex if works in bash would it? hence I took the less elegant but works approach

if [[ -r /etc/alpine-release ] || [[ "${BUILD_CONFIG[OS_KERNEL_NAME]}" == "linux" ] && [ "${BUILD_CONFIG[OS_ARCHITECTURE]}" == "riscv64" ]] ] && [ "$(pwd | wc -c)" -gt 83 ]; then

This is the syntax you're looking for if we're aiming for always on alpine, but also when the path is >83 characters on Linux/riscv64:

if [ -r /etc/alpine-release ] || ( [ "${BUILD_CONFIG[OS_KERNEL_NAME]}" == "linux" ] && [ "${BUILD_CONFIG[OS_ARCHITECTURE]}" == "riscv64" ] && [ "$(pwd | wc -c)" -gt 83 ] ); then ...

[andrew-m-leonard]

Is there a reason this needs to be an elif instead of adding it the section that detects Alpine? This feels like unnecessary duplication

Not sure this complex if works in bash would it? hence I took the less elegant but works approach

if [[ -r /etc/alpine-release ] || [[ "${BUILD_CONFIG[OS_KERNEL_NAME]}" == "linux" ] && [ "${BUILD_CONFIG[OS_ARCHITECTURE]}" == "riscv64" ]] ] && [ "$(pwd | wc -c)" -gt 83 ]; then

This is the syntax you're looking for if we're aiming for always on alpine, but also when the path is >83 characters on Linux/riscv64:

if [ -r /etc/alpine-release ] || ( [ "${BUILD_CONFIG[OS_KERNEL_NAME]}" == "linux" ] && [ "${BUILD_CONFIG[OS_ARCHITECTURE]}" == "riscv64" ] && [ "$(pwd | wc -c)" -gt 83 ] ); then ...

Thanks @sxa updated

[sxa]

We could abstract out the length count from the expression, but sine the linter is happy I'm ok with this and the logic looks sound :-)

[steelhead31]

LGTM