Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cacert: auto update smoke test counter #3702

Merged
merged 1 commit into from
Mar 13, 2024
Merged

Conversation

gdams
Copy link
Member

@gdams gdams commented Mar 12, 2024

As noted in #3697, we still have to manually update the total cert count

Copy link

Thank you for creating a pull request!
If you have not done so already, please familiarise yourself with our Contributing Guidelines and FAQ, even if you have contributed to the Adoptium project before. GitHub actions will now run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A block has been put on this Pull Request as this repository is temporarily under a code freeze due to an ongoing release cycle.

If this pull request needs to be merged during the release cycle then please comment /merge and a PMC member will be able to remove the block.

If the code freeze is over you can remove this block by commenting /thaw.

@gdams
Copy link
Member Author

gdams commented Mar 12, 2024

/merge

Copy link

Approval to merge during the lockdown cycle

Please can two Adoptium PMC members comment /approve?

@smlambert
Copy link
Contributor

/approve

@karianna
Copy link
Contributor

/approve

@github-actions github-actions bot dismissed their stale review March 13, 2024 00:47

Thank you @smlambert and @karianna for your approvals, this pull request is now approved to merge during release.

@karianna
Copy link
Contributor

/thaw

Copy link

Sorry @karianna, the code freeze is still in place.

@karianna karianna merged commit b3deaf5 into adoptium:master Mar 13, 2024
25 checks passed
@gdams gdams deleted the certs branch July 2, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants