-
-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Centralising sbom dependency data, plus adding versions to sboms #3709
Centralising sbom dependency data, plus adding versions to sboms #3709
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A block has been put on this Pull Request as this repository is temporarily under a code freeze due to an ongoing release cycle.
If this pull request needs to be merged during the release cycle then please comment /merge
and a PMC member will be able to remove the block.
If the code freeze is over you can remove this block by commenting /thaw
.
Linked to #3593 |
This is to centralise the jar versions and shas to simplify future updates, and to enable a user to easily set their own values. This also adds cyclonedx dependency version strings to sboms. Signed-off-by: Adam Farley <[email protected]>
f73a928
to
961e606
Compare
…shas_to_build_getdependencies
Tested here: https://ci.adoptium.net/job/build-scripts/job/jobs/job/jdk21u/job/jdk21u-linux-x64-temurin/153/ Passed. SBOM output:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
The license check seems not to apply in this case (as all the failing files contain externally-sourced data such as SHAs, version strings, and jar names), so I've raised a PR to remove the requirement here: |
No freeze on master branch.
This is to centralise the jar versions and shas to simplify future updates, and to enable a user to easily set their own values.
This also adds cyclonedx dependency version strings to sboms.