Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct SBOM Generation Dependency SHAs #3714

Conversation

adamfarley
Copy link
Contributor

Provide SHAs for the individual JARs, rather than using the CycloneDX core jar sha for non-CycloneDX jars.

Addendum: This commit was cherry-picked from the master branch.

Provide SHAs for the individual JARs, rather than using the
CycloneDX core jar sha for non-CycloneDX jars.

Signed-off-by: Adam Farley <[email protected]>
@adamfarley adamfarley self-assigned this Mar 19, 2024
@adamfarley
Copy link
Contributor Author

Testing and reviews can be found here: #3713 (comment)

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A block has been put on this Pull Request as this repository is temporarily under a code freeze due to an ongoing release cycle.

If this pull request needs to be merged during the release cycle then please comment /merge and a PMC member will be able to remove the block.

If the code freeze is over you can remove this block by commenting /thaw.

@adamfarley
Copy link
Contributor Author

/merge

Copy link

Approval to merge during the lockdown cycle

Please can two Adoptium PMC members comment /approve?

@gdams
Copy link
Member

gdams commented Mar 19, 2024

/approve

@adamfarley
Copy link
Contributor Author

Thanks @gdams :)

@karianna
Copy link
Contributor

/approve

@github-actions github-actions bot dismissed their stale review March 20, 2024 00:09

Thank you @gdams and @karianna for your approvals, this pull request is now approved to merge during release.

@karianna karianna merged commit ee31d1e into adoptium:v2024.03.01 Mar 20, 2024
4 checks passed
@adamfarley adamfarley deleted the fix_sbom_shas_for_cyclonedx_dependencies_in_release_branch branch July 10, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants