Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add getDependentLibs for smoke test #3719

Merged
merged 1 commit into from
Mar 20, 2024
Merged

Conversation

LongyuZhang
Copy link
Contributor

- Add getDependentLibs for smoke test

Signed-off-by: LongyuZhang <[email protected]>
Copy link

Thank you for creating a pull request!
If you have not done so already, please familiarise yourself with our Contributing Guidelines and FAQ, even if you have contributed to the Adoptium project before. GitHub actions will now run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

@github-actions github-actions bot added openj9 Issues that are enhancements or bugs raised against the OpenJ9 group testing Issues that enhance or fix our test suites labels Mar 19, 2024
@LongyuZhang
Copy link
Contributor Author

Test Links:

16:26:40  getDependentLibs:
16:26:40       [exec] --------------------------------------------
16:26:40       [exec] path is set to /home/jenkins/workspace/Grinder/../../testDependency/lib
16:26:40       [exec] task is set to default
16:26:40       [exec] dependencyList is set to testng
16:26:40       [exec] --------------------------------------------
16:26:40       [exec] Starting download third party dependent jars
16:26:40       [exec] --------------------------------------------
16:26:40       [exec] downloading dependent third party jars to /home/jenkins/workspace/Grinder/../../testDependency/lib
16:26:40       [exec] /home/jenkins/workspace/Grinder/../../testDependency/lib/testng.jar exists with correct hash, not downloading
16:26:40       [exec] downloaded dependent third party jars successfully
  • openj9: hyc_grinder 38915

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A block has been put on this Pull Request as this repository is temporarily under a code freeze due to an ongoing release cycle.

If this pull request needs to be merged during the release cycle then please comment /merge and a PMC member will be able to remove the block.

If the code freeze is over you can remove this block by commenting /thaw.

@LongyuZhang
Copy link
Contributor Author

@smlambert @sophia-guo @llxia Could you review it? Thanks.

Copy link
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smlambert
Copy link
Contributor

/merge

Copy link

Approval to merge during the lockdown cycle

Please can two Adoptium PMC members comment /approve?

@smlambert
Copy link
Contributor

/approve

1 similar comment
@llxia
Copy link
Contributor

llxia commented Mar 19, 2024

/approve

@github-actions github-actions bot dismissed their stale review March 19, 2024 21:41

Thank you @smlambert and @llxia for your approvals, this pull request is now approved to merge during release.

@karianna karianna merged commit f47b8ac into adoptium:master Mar 20, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
openj9 Issues that are enhancements or bugs raised against the OpenJ9 group testing Issues that enhance or fix our test suites
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants