comparable_patch.sh: Zero out .gnu_debuglink CRCs (#3730) #3736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
|
Looks great: |
andrew-m-leonard
requested changes
Mar 28, 2024
fitzsim
force-pushed
the
comparable-patch-zero-gnu-debuglink-crc
branch
2 times, most recently
from
f10f4fc to
4660ca4
Compare
|
I used the button here to rebase my pull request branch onto the master branch. |
fitzsim
force-pushed
the
comparable-patch-zero-gnu-debuglink-crc
branch
from
4660ca4 to
c95aa58
Compare
andrew-m-leonard
approved these changes
Mar 28, 2024
karianna
approved these changes
Mar 30, 2024
|
@fitzsim looks like Mac OS X 13 build is failing, likely due to an unrelated reason. Have you rebased recently? |
fitzsim
force-pushed
the
comparable-patch-zero-gnu-debuglink-crc
branch
from
c95aa58 to
ccedeeb
Compare
|
Hi @karianna, thank you for reviewing. I did rebase just after I originally submitted the pull request. I just now rebased again. |
|
The assert line (line number 58 in jfrNetworkUtilization.cpp) that fails to compile on macos-13 is the same across jdk8u, jdk11u, and jdk17u. I wonder why the (macos-13, jdk11u) build fails where the (macos-14, jdk17u) and (macos-11, jdk8u) builds succeed. |
|
#3737 is failing the same way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request replaces #3732. Instead of removing the .gnu_debuglink section, this patch set changes just the four CRC bytes in that ELF section to 0.