-
-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
making build -D working with podman #3796
Merged
+134
−47
Merged
Changes from all commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
da29366
added podman to switches
judovana 04b28dc
Adjusted signalHandler to countwith podman/docker
judovana 6b43591
reworked BUILD_CONFIG[DOCKER] to contain only sudo information
judovana ce82463
using the BUILD_CONFIG[DOCKER] BUILD_CONFIG[USE_DOCKER] combo proeprly
judovana 9e653f3
On podman, set --userns=keep-id
judovana 743f470
porecreate all necessary dirs
judovana 480aa29
Added warinbg to `docker build` command when used with podman
judovana e3af8d2
Using absolute path instead of "."
judovana 092d192
docker-build.sh jsut-> just
judovana fa34c0d
Removed unused parameter of buildOpenJDKViaDocker
judovana 3d2a7a5
use which podman without [] and to dev/null
judovana 20f6965
Revert "Using absolute path instead of ".""
judovana 4db5724
Fixed issue with missing test for mk-ca-bundle.pl
judovana 04f44ab
Always generate configure-and-build.sh
judovana 56df908
Removed more hardcoded dockers
judovana a1a3d57
Do not set boot jdk for docekr builds (it is removed later anyway)
judovana e566202
Added few more missing dirs
judovana 18ef020
Fixed boot jdk check against new docker/podman/false
judovana f1d8611
replacing missed ${BUILD_CONFIG[DOCKER]} by ${BUILD_CONFIG[DOCKER]} "…
judovana ae65c64
instead of workspace/build/src creatig directly /workspace/build
judovana 67f3187
Remoed accident tab
judovana bab4397
Added support for building local dir/src tarball in contianer
judovana 73c43c5
Removed wrongly added ASSEMBLE_EXPLODED_IMAGE=true to container builds
judovana 160b762
used -n instead of '! -z '
judovana 51ccc93
Highlighted sudo for dcoekr
judovana 35201e2
Added missing bracket
judovana e383554
Fixed typo
judovana f1b9336
Mentioned issue with --custom-cacerts on podman
judovana 43af711
renamed USE_DOCKER->CONTAINER_COMMAND DOCKER->CONTAINER_AS_ROOT
judovana 10e228d
Improved warning about --custom-cacerts
judovana File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason not to make this
-D
now?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had left
-D
to autodetect. Id there is podman, it will be used. If not, docekr will be used. Reason for this fallback is that if you have podman, you have also docker aliases. But if you have docker, you do no thave podman aliases.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep understood - I just wasn't sure why this example was explicitly switched to
--podman
instead of showing the "autodetect" versionThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I jsut wanted to keep all three there. If they should be reuced, jsut say.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a slight preference fur using the generic
-D
, although I quite like the multiple examples too, so no real preference with your explaination :-)