Fix segfault from my last SNI changes #1173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DimitriPapadopoulos
force-pushed
the
sni
branch
from
14260ef
to
8b80340
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
- Use the same maximum length `GATEWAY_HOST_SIZE`. - Handle `sni` as a fixed-length array instead of a pointer to dynamically allocated memory. Fix the current segfault in the process, which can be explained by improper handling of the allocated memory in `merge_config()`, where we would try to merge fixed-size arrays instead of pointers to allocated memory. Now we handle fixed-size arrays everywhere.
DimitriPapadopoulos
force-pushed
the
sni
branch
from
8b80340
to
ffc1da1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deal with
snithe same way asgateway_hostGATEWAY_HOST_SIZE.snias a fixed-length array instead of a pointer to dynamically allocated memory. Fix the current segfault in the process, which can be explained by improper handling of the allocated memory inmerge_config(), where we would try to merge fixed-size arrays instead of pointers to allocated memory. Now we try to merge fixed-size arrays everywhere.