-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Framelabels #208
base: master
Are you sure you want to change the base?
Framelabels #208
Conversation
Also plundered some little playback helpers (play,stop, and get/set frame) from here: josimard@e486575
|
||
sprite.alpha._ = alpha; | ||
sprite.alpha._ = alpha; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a lot of weird reformatting in this PR :) Please try to match the project code-style and avoid cluttering the diff with lots of reformatting.
Ok, makes sense. I'll take a look at MovieKeyframe (and watch the formatting) |
I made some changes in my main fork... hopefully this is towards what you wanted:
|
Possible bug: Some emits are skipped if the position seeks past multiple labels in a single update (happens consistently if two labels point at the same frame) I also wonder if a |
Yeah, I had a String Map earlier but wasn't sure which approach I preferred. Happy to go back to it. Agree about moving to MovieSymbol for most of the implementation, should help sort out the skipped label emit bug too. |
Moved most framelabel related bits into MovieSymbol in this commit: |
Would love to see these features integrated into the framework, any ETA on this? Thanks! |
Have another look at the state of the framelabels branch - I've tidied up and reverted changes that were not directly related to framelabels support. I'm using it with flump exported animations on a flash/html5 project, and it seems stable. |
Thanks Mike, I'll take a look at it ASAP! |
Nudge! Our animators would love you if frame labels were supported. Any updates on when this can be implemented? |
Adding Flump frame-label support for MovieSprite - #54
Also plundered some playback helpers (play,stop, get/set frame) from here:
pheno7@e486575