Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framelabels #208

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Framelabels #208

wants to merge 4 commits into from

Conversation

mikedotalmond
Copy link

Adding Flump frame-label support for MovieSprite - #54

Also plundered some playback helpers (play,stop, get/set frame) from here:
pheno7@e486575

Mike Almond added 2 commits December 12, 2013 16:59
Also plundered some little playback helpers (play,stop, and get/set frame) from here:
josimard@e486575

sprite.alpha._ = alpha;
sprite.alpha._ = alpha;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a lot of weird reformatting in this PR :) Please try to match the project code-style and avoid cluttering the diff with lots of reformatting.

@mikedotalmond
Copy link
Author

Ok, makes sense. I'll take a look at MovieKeyframe (and watch the formatting)

@mikedotalmond
Copy link
Author

I made some changes in my main fork... hopefully this is towards what you wanted:
mikedotalmond@aaeb792

  • moved most of the label support stuff out of MovieSprite and into MovieSymbol/MovieLayer,
  • support/allow frame-labels on any movie layer
  • each LayerAnimator in a MovieSprite manages a currentLabel and labelChanged property in the .composeFrame call.

@aduros
Copy link
Owner

aduros commented Dec 16, 2013

Possible bug: Some emits are skipped if the position seeks past multiple labels in a single update (happens consistently if two labels point at the same frame)

I also wonder if a labels :Map<String,Float> on MovieSymbol wouldn't be better than the new exposed MovieLayer fields. That would simplify two common use-cases (a) getting a time position out of a label so you can seek to it (b) enumerating over all the labels. The MovieLayer array fields should be private implementation detail (seems also like they should be lifted to MovieSymbol).

@mikedotalmond
Copy link
Author

Yeah, I had a String Map earlier but wasn't sure which approach I preferred. Happy to go back to it.

Agree about moving to MovieSymbol for most of the implementation, should help sort out the skipped label emit bug too.

@mikedotalmond
Copy link
Author

Moved most framelabel related bits into MovieSymbol in this commit:
mikedotalmond@bde91cb

@quinnhoener
Copy link

Would love to see these features integrated into the framework, any ETA on this?

Thanks!

@mikedotalmond
Copy link
Author

Have another look at the state of the framelabels branch - I've tidied up and reverted changes that were not directly related to framelabels support. I'm using it with flump exported animations on a flash/html5 project, and it seems stable.

@aduros
Copy link
Owner

aduros commented Jan 13, 2014

Thanks Mike, I'll take a look at it ASAP!

@quinnhoener
Copy link

Nudge! Our animators would love you if frame labels were supported. Any updates on when this can be implemented?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants