Skip to content
This repository has been archived by the owner on Feb 14, 2020. It is now read-only.

[TST-18] added refs to jira TST board #788

Merged
merged 1 commit into from
Mar 16, 2017

Conversation

EpicNuts
Copy link

TST-18

TST-18

added reference to Jira

@codecov-io
Copy link

codecov-io commented Mar 16, 2017

Codecov Report

Merging #788 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #788   +/-   ##
=======================================
  Coverage   65.53%   65.53%           
=======================================
  Files         161      161           
  Lines        3128     3128           
  Branches       49       49           
=======================================
  Hits         2050     2050           
  Misses       1078     1078

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73aa885...e85e20c. Read the comment docs.

@codders codders self-requested a review March 16, 2017 13:41
Copy link

@codders codders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move this comment to the top of the file, consider adding meta tags.

@@ -84,3 +84,4 @@
</tbody></table>
</body>
</html>
<!--covers test TST-18-->
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would make more sense to me to have this closer to the start of the file. Is there a reason to drop it at the end?
Also, do you think it would make sense to add this as a meta-tag?

<meta name="ats:test-case" content="Vehicle whatever test">
<meta name="ats:test-jira-ticket" content="TST-18">
<meta name="ats:test-jira-url" content="https://advancedtelematic...">

Or is your HTML somehow auto-generated?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's auto generated. The way I have it now basically adds a comment in the script that appears in the Selenium IDE UI. I'll see how it handles meta tags though, and if it doesn't break, go with that.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also put it at the end because there would be another couple of tickets that this test case covers, and having them stacked at the end looked 'right' to me. So no valid reason really :D

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per slack, let's extend the name="" attribute to include the test ID. That will allow us to support multiple tickets in the same file.

@EpicNuts EpicNuts force-pushed the feat/TST-18/return-Device-List branch from b6f961f to cdd7ea2 Compare March 16, 2017 15:03
@EpicNuts EpicNuts force-pushed the feat/TST-18/return-Device-List branch from cdd7ea2 to e85e20c Compare March 16, 2017 15:07
@EpicNuts EpicNuts changed the title added reference to TST-18 [TST-18] added refs to jira TST board Mar 16, 2017
Copy link

@codders codders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@EpicNuts EpicNuts merged commit 5be6a9b into master Mar 16, 2017
@EpicNuts EpicNuts deleted the feat/TST-18/return-Device-List branch March 16, 2017 15:38
@EpicNuts
Copy link
Author

bombs away! :D

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants