-
Notifications
You must be signed in to change notification settings - Fork 4
Conversation
Codecov Report
@@ Coverage Diff @@
## master #788 +/- ##
=======================================
Coverage 65.53% 65.53%
=======================================
Files 161 161
Lines 3128 3128
Branches 49 49
=======================================
Hits 2050 2050
Misses 1078 1078 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move this comment to the top of the file, consider adding meta tags.
@@ -84,3 +84,4 @@ | |||
</tbody></table> | |||
</body> | |||
</html> | |||
<!--covers test TST-18--> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would make more sense to me to have this closer to the start of the file. Is there a reason to drop it at the end?
Also, do you think it would make sense to add this as a meta-tag?
<meta name="ats:test-case" content="Vehicle whatever test">
<meta name="ats:test-jira-ticket" content="TST-18">
<meta name="ats:test-jira-url" content="https://advancedtelematic...">
Or is your HTML somehow auto-generated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's auto generated. The way I have it now basically adds a comment in the script that appears in the Selenium IDE UI. I'll see how it handles meta tags though, and if it doesn't break, go with that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also put it at the end because there would be another couple of tickets that this test case covers, and having them stacked at the end looked 'right' to me. So no valid reason really :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per slack, let's extend the name="" attribute to include the test ID. That will allow us to support multiple tickets in the same file.
b6f961f
to
cdd7ea2
Compare
cdd7ea2
to
e85e20c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
bombs away! :D |
TST-18
TST-18
added reference to Jira