Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++ Wrapper] tidy up AgentRunner.h and AgentInvoker.h construction #1750

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions aeron-client/src/main/cpp_wrapper/concurrent/AgentInvoker.h
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ template<typename Agent>
class AgentInvoker
{
public:
AgentInvoker(Agent &agent, util::exception_handler_t &exceptionHandler) :
AgentInvoker(Agent &agent, const util::exception_handler_t &exceptionHandler) :
m_agent(agent),
m_exceptionHandler(exceptionHandler)
{
Expand Down Expand Up @@ -140,7 +140,7 @@ class AgentInvoker

private:
Agent &m_agent;
util::exception_handler_t &m_exceptionHandler;
const util::exception_handler_t &m_exceptionHandler;
bool m_isStarted = false;
bool m_isRunning = false;
bool m_isClosed = false;
Expand Down
6 changes: 3 additions & 3 deletions aeron-client/src/main/cpp_wrapper/concurrent/AgentRunner.h
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ template <typename Agent, typename IdleStrategy>
class AgentRunner
{
public:
AgentRunner(Agent &agent, IdleStrategy &idleStrategy, util::exception_handler_t &exceptionHandler) :
AgentRunner(Agent &agent, IdleStrategy &idleStrategy, const util::exception_handler_t &exceptionHandler) :
m_agent(agent),
m_idleStrategy(idleStrategy),
m_exceptionHandler(exceptionHandler),
Expand All @@ -48,7 +48,7 @@ class AgentRunner
AgentRunner(
Agent &agent,
IdleStrategy &idleStrategy,
util::exception_handler_t &exceptionHandler,
const util::exception_handler_t &exceptionHandler,
const std::string &name) :
m_agent(agent),
m_idleStrategy(idleStrategy),
Expand Down Expand Up @@ -197,7 +197,7 @@ class AgentRunner
private:
Agent &m_agent;
IdleStrategy &m_idleStrategy;
util::exception_handler_t &m_exceptionHandler;
const util::exception_handler_t &m_exceptionHandler;
std::atomic<bool> m_isStarted = { false };
std::atomic<bool> m_isRunning = { false };
std::atomic<bool> m_isClosed = { false };
Expand Down
Loading