Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added AtomicBuffer compareAndExchange int/long #334

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions agrona/src/main/java/org/agrona/concurrent/AtomicBuffer.java
Original file line number Diff line number Diff line change
Expand Up @@ -218,6 +218,19 @@ public interface AtomicBuffer extends MutableDirectBuffer
*/
boolean compareAndSetLong(int index, long expectedValue, long updateValue);

/**
* Atomic compare and exchange of a long given an expected value.
* <p>
* This call has sequential-consistent semantics.
*
* @param index in bytes for where to put.
* @param expectedValue at to be compared.
* @param updateValue to be exchanged.
* @return the old value no matter if the expected value was found.
* @since 2.1.0
*/
long compareAndExchangeLong(int index, long expectedValue, long updateValue);

/**
* Atomically exchange a value at a location returning the previous contents.
* <p>
Expand Down Expand Up @@ -359,6 +372,20 @@ public interface AtomicBuffer extends MutableDirectBuffer
*/
boolean compareAndSetInt(int index, int expectedValue, int updateValue);

/**
* Atomic compare and exchange of a int given an expected value.
* <p>
* This call has sequential-consistent semantics.
*
* @param index in bytes for where to put.
* @param expectedValue at to be compared.
* @param updateValue to be exchanged.
* @return the old value no matter if the expected value was found.
* @since 2.1.0
*/
int compareAndExchangeInt(int index, int expectedValue, int updateValue);


/**
* Atomically exchange a value at a location returning the previous contents.
* <p>
Expand Down
27 changes: 27 additions & 0 deletions agrona/src/main/java/org/agrona/concurrent/UnsafeBuffer.java
Original file line number Diff line number Diff line change
Expand Up @@ -508,6 +508,20 @@ public boolean compareAndSetLong(final int index, final long expectedValue, fina
return UnsafeApi.compareAndSetLong(byteArray, addressOffset + index, expectedValue, updateValue);
}

/**
* {@inheritDoc}
*/
public long compareAndExchangeLong(final int index, final long expectedValue, final long updateValue)
{
if (SHOULD_BOUNDS_CHECK)
{
boundsCheck0(index, SIZE_OF_LONG);
}

return UnsafeApi.compareAndExchangeLong(byteArray, addressOffset + index, expectedValue, updateValue);
}


/**
* {@inheritDoc}
*/
Expand Down Expand Up @@ -671,6 +685,19 @@ public boolean compareAndSetInt(final int index, final int expectedValue, final
return UnsafeApi.compareAndSetInt(byteArray, addressOffset + index, expectedValue, updateValue);
}

/**
* {@inheritDoc}
*/
public int compareAndExchangeInt(final int index, final int expectedValue, final int updateValue)
{
if (SHOULD_BOUNDS_CHECK)
{
boundsCheck0(index, SIZE_OF_INT);
}

return UnsafeApi.compareAndExchangeInt(byteArray, addressOffset + index, expectedValue, updateValue);
}

/**
* {@inheritDoc}
*/
Expand Down
36 changes: 36 additions & 0 deletions agrona/src/test/java/org/agrona/concurrent/AtomicBufferTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,24 @@ void shouldCompareAndSetLongToNativeBuffer(final ByteBuffer buffer)
assertThat(buffer.getLong(INDEX), is(LONG_VALUE + 1));
}

@ParameterizedTest
@MethodSource("atomicBuffers")
void shouldCompareAndExchangeLongToNativeBuffer(final ByteBuffer buffer)
{
final UnsafeBuffer unsafeBuffer = new UnsafeBuffer(buffer);

buffer.putLong(INDEX, LONG_VALUE);

// success
assertEquals(LONG_VALUE, unsafeBuffer.compareAndExchangeLong(INDEX, LONG_VALUE, LONG_VALUE + 1));
assertEquals(LONG_VALUE + 1, unsafeBuffer.getLongVolatile(INDEX));

// failure
assertEquals(LONG_VALUE + 1,
unsafeBuffer.compareAndExchangeLong(INDEX, LONG_VALUE + 10, 21));
assertEquals(LONG_VALUE + 1, buffer.getLong(INDEX));
}

@ParameterizedTest
@MethodSource("atomicBuffers")
void shouldGetAndSetLongToNativeBuffer(final ByteBuffer buffer)
Expand Down Expand Up @@ -251,6 +269,24 @@ void shouldCompareAndSetIntToNativeBuffer(final ByteBuffer buffer)
assertThat(buffer.getInt(INDEX), is(INT_VALUE + 1));
}

@ParameterizedTest
@MethodSource("atomicBuffers")
void shouldCompareAndExchangeIntToNativeBuffer(final ByteBuffer buffer)
{
final UnsafeBuffer unsafeBuffer = new UnsafeBuffer(buffer);

buffer.putInt(INDEX, INT_VALUE);

// success
assertEquals(INT_VALUE, unsafeBuffer.compareAndExchangeInt(INDEX, INT_VALUE, INT_VALUE + 1));
assertEquals(INT_VALUE + 1, unsafeBuffer.getIntVolatile(INDEX));

// failure
assertEquals(INT_VALUE + 1,
unsafeBuffer.compareAndExchangeInt(INDEX, INT_VALUE + 10, 21));
assertEquals(INT_VALUE + 1, buffer.getInt(INDEX));
}

@ParameterizedTest
@MethodSource("atomicBuffers")
void shouldGetAndSetIntToNativeBuffer(final ByteBuffer buffer)
Expand Down