Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 5.13.0 #633

Open
wants to merge 40 commits into
base: stage
Choose a base branch
from
Open

Release 5.13.0 #633

wants to merge 40 commits into from

Conversation

DomPeliniAerospike
Copy link
Collaborator

No description provided.

DomPeliniAerospike and others added 3 commits October 14, 2024 09:29
CLIENT-3061
CLIENT-3127
CLIENT-3145

// Collaborator
@bit0r1n - Use his typings as a starting point for the revamp!  Thank you very much for contributing, and sorry it took so long to finally complete.
realmgic
realmgic previously approved these changes Oct 16, 2024
@@ -402,7 +416,7 @@ exports.log = as.log
*
* @property {number} NAMESPACE_DEFAULT - Use the default TTL value for the
* namespace of the record.
* @property {number} NEVER_EXIRE - Never expire the record.
* @property {number} NEVER_EXpIRE - Never expire the record.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the p in lowercase?

@@ -0,0 +1,57 @@
// *****************************************************************************
// Copyright 2013-2023 Aerospike, Inc.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2024?

@@ -0,0 +1,96 @@
// *****************************************************************************
// Copyright 2013-2023 Aerospike, Inc.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2024 - this repeats to all test files and should be fixed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably need to go into gitignore

k.js Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be removed or ignored

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants