Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLIENT-3106] aerospike.exception: create a Python dict that maps as_status error codes to Aerospike exception classes to speed up raising exceptions #663

Draft
wants to merge 31 commits into
base: dev
Choose a base branch
from

Conversation

juliannguyen4
Copy link
Collaborator

@juliannguyen4 juliannguyen4 commented Aug 30, 2024

Missing test coverage:

  • Exception for error code returned by the C client was not found, so use AerospikeError as the default exception

Extra changes:

  • Remove unused header file exception_types.h
  • in_doubt attribute is now included with all exception classes by default, instead of only when the client raises an AerospikeError
  • Fix bug when operate() throws an exception and deletes the "bin" attribute from the exception class
  • Only support one aerospike module per interpreter

TODO

  • Skipped client/info.c. needs code coverage and code might be wrong

@codecov-commenter
Copy link

codecov-commenter commented Aug 30, 2024

Codecov Report

Attention: Patch coverage is 71.87500% with 45 lines in your changes missing coverage. Please review.

Project coverage is 80.93%. Comparing base (8ff0327) to head (68ba61a).
Report is 2 commits behind head on dev.

Files with missing lines Patch % Lines
src/main/exception.c 70.19% 31 Missing ⚠️
src/main/client/info.c 33.33% 6 Missing ⚠️
src/main/query/where.c 0.00% 3 Missing ⚠️
src/main/client/sec_index.c 50.00% 2 Missing ⚠️
src/main/scan/apply.c 0.00% 2 Missing ⚠️
src/main/client/batch_get_ops.c 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #663      +/-   ##
==========================================
+ Coverage   80.89%   80.93%   +0.04%     
==========================================
  Files         100      100              
  Lines       15053    14893     -160     
==========================================
- Hits        12177    12054     -123     
+ Misses       2876     2839      -37     
Flag Coverage Δ
80.93% <71.87%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from CLIENT-3106-c-glue-code-refactor to dev September 9, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants