Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEVOPS-234] CI/CD: Reuse builds for feature branches in Github Actions workflows #670

Draft
wants to merge 22 commits into
base: dev
Choose a base branch
from

Conversation

juliannguyen4
Copy link
Collaborator

@juliannguyen4 juliannguyen4 commented Sep 11, 2024

Reason for this change: it will be a while to clean up all the memory leaks while running the Python client regression tests, and we normally run valgrind manually. We won't be running valgrind as a CI/CD check for a while because of this. Often times, the valgrind workflow builds a wheel when a wheel was already built for the same commit. This change forces valgrind to reuse a wheel (from JFrog) if it already exists

  • Code reviewed
  • First valgrind run builds new wheel
  • Second valgrind run uses wheel built in first run
  • When there are two wheels for the same commit, the one with no labels is used
  • No regression when running valgrind run on central branch

@codecov-commenter
Copy link

codecov-commenter commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.89%. Comparing base (d1e7bc2) to head (33a70d3).
Report is 16 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #670      +/-   ##
==========================================
- Coverage   80.96%   80.89%   -0.08%     
==========================================
  Files         100      100              
  Lines       15130    15053      -77     
==========================================
- Hits        12250    12177      -73     
+ Misses       2880     2876       -4     
Flag Coverage Δ
80.89% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants