Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FMWK-530 Fix handlers .Wait() context #111

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

filkeith
Copy link
Contributor

@filkeith filkeith commented Aug 7, 2024

  • removed context from handlers .Wait() methods
  • pass global backup context to handlers

- removed context from handlers .Wait() methods
- pass global backup context to handlers
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.57%. Comparing base (055bdb3) to head (5099b78).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #111      +/-   ##
==========================================
+ Coverage   80.44%   80.57%   +0.13%     
==========================================
  Files          62       62              
  Lines        3216     3218       +2     
==========================================
+ Hits         2587     2593       +6     
+ Misses        436      432       -4     
  Partials      193      193              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@reugn reugn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As to our discussion, we'll need to refactor the logic and evaluate the option of returning the context parameter.

@filkeith filkeith merged commit c03293a into main Aug 7, 2024
5 checks passed
@filkeith filkeith deleted the FMWK-530-fix-handlers-wait-ctx branch August 7, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants