FMWK-48 Spring Data Aerospike Cacheable sync option #755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reugn
reviewed
Jun 18, 2024
| @@ -112,20 +112,48 @@ public Object getNativeCache() { | |||
| * @return The value (bins) to which this cache maps the specified key. | |||
| */ | |||
| @Override | |||
| @SuppressWarnings({"unchecked", "NullableProblems"}) | |||
| @SuppressWarnings({"NullableProblems"}) | |||
There was a problem hiding this comment.
Suggested change
| @SuppressWarnings({"NullableProblems"}) | |
| @SuppressWarnings("NullableProblems") |
| } | ||
| } | ||
| return value; | ||
| if (record.getValue(VALUE) != null) { |
There was a problem hiding this comment.
record or valueLoader can be null here.
| AerospikeReadData data = AerospikeReadData.forRead(dbKey, record); | ||
| Class<T> type = getValueType(valueLoader); // determine the class of T | ||
| return aerospikeConverter.read(type, data); | ||
| } else { |
roimenashe
approved these changes
Jun 18, 2024
reugn
reviewed
Jun 18, 2024
Comment on lines
117
to
118
| Key dbKey = getKey(key); | ||
| Record record = client.get(null, dbKey); |
There was a problem hiding this comment.
Should go under the following if.
| } | ||
| } catch (Exception e) { | ||
| throw new Cache.ValueRetrievalException(key, valueLoader, e); | ||
| } else if (record.getValue(VALUE) != null) { |
There was a problem hiding this comment.
Suggested change
| } else if (record.getValue(VALUE) != null) { | |
| } | |
| if (record.getValue(VALUE) != null) { |
reugn
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.