-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add negative-binomial conjugate rewrite #105
Conversation
I think |
Yeah, I think we need #94 to fix that. I'll set up some |
bcccf51
to
fec6051
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #105 +/- ##
==========================================
+ Coverage 98.16% 98.50% +0.34%
==========================================
Files 10 10
Lines 708 737 +29
Branches 63 63
==========================================
+ Hits 695 726 +31
+ Misses 5 4 -1
+ Partials 8 7 -1 ☔ View full report in Codecov by Sentry. |
I fixed the formatting issues and added a test to make sure the rewrite is picked by |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just some minor formatting recommendations. Thanks again, @xjing76!
13ebe8d
to
e9604d4
Compare
e9604d4
to
087df87
Compare
This PR will add in NB-beta conjugates along with its tests.
Because the
at.random.negative_binomial
takes in the number of successes and I switched the the formula for beta and alpha suggested hereThis PR is working towards Issue#48