Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Massive rework for .18 #16

Open
wants to merge 43 commits into
base: master
Choose a base branch
from
Open

Massive rework for .18 #16

wants to merge 43 commits into from

Conversation

TimVroom
Copy link

Reworked to be up to coding standards for 0.18 / 1.0
Currently incorrect/now working: train schedules/trips.

Added a lot of stats to the exporting (force/robots etc)
Added power for exporting
Added mod/game info to the export.

TimVroom added 29 commits July 29, 2020 22:22
@TimVroom
Remastering of graftorio for nilaus' usage
f76fe36
@TimVroom
Minor fixes...
b016b10
@TimVroom
Minor train fix
8e49203
@TimVroom
Adding additional and multiple stats to track
df3bc94
@TimVroom
Merge branch 'master' of github.com:afex/graftorio
652e2a4
@TimVroom
Minor typo's
25e2e9c
@TimVroom
Bugfixes and more cleanup.
2038f55 
- More localized vars
- Proper export of values such as research queue
- Removed some unneeded events in loading
@TimVroom
Massive change - separated to different libs so its more manageable
181022e
@TimVroom
Changed one missed game.tick to event.tick
d75d681
@TimVroom
Updated version for deploy
71f74a0
@TimVroom
Added power tracker
494a037
@TimVroom
Updated version and seperate calculation before sending out in different
a3275ce 
ticks
@TimVroom
Performance improvements
f61cb9b 
Disabled train tracking for now (instable)
Added polution tracking
Added total charging bots for every cell in a network
@TimVroom
Updated it all again...
a659dde
@TimVroom
Minor fix for deconstruction
cf574dc
@TimVroom
Updated version
85a6462
@TimVroom
Added example dashboards
f6af030 
Updated readme.
Added example env.grafana
@TimVroom
Added plugin support so other mods can hook into graftorio
3313049
@TimVroom
Made sure events are not in global space, they can change when altering
7ce690b 
mods...
Updated version number
@TimVroom
Updated version and changelog.
46e6b49 
Make sure some gauges are reset when needed
@TimVroom
Make sure its the same versioning
5b5b054
@TimVroom
Make sure plugins can actually work...
a3fefb1 
Removed some unuseable prometheus stuff
@TimVroom
Updated version
18e92cb
@TimVroom
Updated to .15, making sure plugins works
3b23820
@TimVroom
Added automatic translation using the players. SHould only be done once
9eff35c 
the game is loaded.
@TimVroom
Updated so it keeps original full name
867ada3
@TimVroom
Fixed typo
b2c45da
@TimVroom
Updated translations and fixing research queue (mostly)
52302aa
@TimVroom
Better fix for correct level selection
9360d05
@SnO2WMaN
Copy link

@TimVroom Your rework version works very well (at least in my env). However this original mod owners seems not to be active on GitHub for a long time, so I think this pull request may not to be merged. Do you have a thought to release your reworked version as like graftorio2?

P.S. I found some typo in README.md and mod output data.

@TimVroom
Updated to .20
c12524c
@TimVroom
Added distribute code.
97894f2 
Updated so it allows for row titles to include icons

added # option to keep - instead of replacing with _
@attrib
Copy link

attrib commented Aug 23, 2020 •
edited
Loading

Also tested it quickly and all seems to work with 1.0. But I do not want to enable the whole time, as this would need all users to download it manually. So can't test it currently with multiple players online at the moment.

TimVroom added 10 commits August 31, 2020 14:48
@TimVroom
Removed proxies, but replaced all localised strings with their
31b2eef 
item/entity prototype when needed.
@TimVroom
Minor fixes and more info for export
6d93386
@TimVroom
Updated changelog
054ce0f
@TimVroom
Updated translation to not be crashing...
92df7ac
@TimVroom
Minor fix again...
758fbcc
@TimVroom
Split out the events more so it would clutter less.
3ea1d62 
Make sure the export function isn't to big and causes lag spikes.
Chunked the collectors up and do it in a few ticks instead of 1.

Disabled the logistics collecting again (too intensive for big networks)
@TimVroom
Forgot control.lua
0c1a74b
@TimVroom
Updated version
1d7f402
@TimVroom
Updated tick delay and made server only save possible
66230d2
@TimVroom
Merge branch 'development' into 'master'
d282744 
Updated tick delay and made server only save possible

See merge request thevirtualcrewprojects/graftorio!1
@wbourne0
Copy link

wbourne0 commented Sep 16, 2020 •
edited
Loading

The mod does seem to work with v1.0 but we're getting this issue occasionally when saving the map:

2427.751 Error ParallelScenarioSaver.cpp:114: Saving scenario failed: The mod graftorio (1.0.25) caused a non-recoverable error.
Please report this error to the mod author.

Error while running event graftorio::on_save()
LuaCustomTable cannot be serialized.
2427.761 Error Util.cpp:83: Attempting to create notice box in headless mode. Message: 'Cannot save map: The mod graftorio (1.0.25) caused a non-recoverable error.
Please report this error to the mod author.

Error while running event graftorio::on_save()
LuaCustomTable cannot be serialized.'

@wbourne0
Copy link

wbourne0 commented Dec 2, 2020

@TimVroom do these fix the issue that I pointed out?

@TimVroom
Copy link
Author

TimVroom commented Dec 3, 2020

Also tested it quickly and all seems to work with 1.0. But I do not want to enable the whole time, as this would need all users to download it manually. So can't test it currently with multiple players online at the moment.

Yes it seems to work okay ish on 1.0. There is currently a setting that is enabled by default to only save on the server, so that saves a little bit of ups for the users.

@TimVroom do these fix the issue that I pointed out?

It should be yes, be aware that it might be a bit slower on bigger bases.

@jlucktay
Copy link

I recommend taking a look at the new graftorio2 fork here and recreating/adapting this PR as necessary. 😃

@aritas1 aritas1 mentioned this pull request Feb 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TimVroom @SnO2WMaN @attrib @wbourne0 @jlucktay