Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change the notation for tnth from \_ to avoid a conflict with mca #110

Merged
merged 3 commits into from
Dec 8, 2023

Conversation

t6s
Copy link
Collaborator

@t6s t6s commented Dec 7, 2023

The notation \_ for tnth defined in ssr_ext.v (at level 9) conflicts with the one in classical_sets (at level 10),
blocking uses of mathcomp-analysis at some places, particularly when trying to reboot PR #67 .

This PR replaces it by \__ (one extra underscore) to avoid the conflict.

@t6s
Copy link
Collaborator Author

t6s commented Dec 7, 2023

I also noticed a few lemmas marked in bayes.v to be moved to ssr_ext.v, and did it.

@affeldt-aist affeldt-aist self-requested a review December 7, 2023 23:55
@affeldt-aist
Copy link
Owner

affeldt-aist commented Dec 8, 2023

This is fine with me. Have you considered other notations of less than 3 characters? Maybe !_ could have worked. It looks like array addressing to me, which seems appropriate here. (This could even be proposed at the MathComp level.)

@affeldt-aist
Copy link
Owner

This is fine with me. Have you considered other notations of less than 3 characters? Maybe !_ could have worked. It looks like array addressing to me, which seems appropriate here. (This could even be proposed at the MathComp level.)

Haskell is using ! for array subscripting by the way.

@t6s
Copy link
Collaborator Author

t6s commented Dec 8, 2023

This is fine with me. Have you considered other notations of less than 3 characters? Maybe !_ could have worked. It looks like array addressing to me, which seems appropriate here. (This could even be proposed at the MathComp level.)

No, and I have no particular preference. Which do you really like?

@affeldt-aist
Copy link
Owner

in the circumstances, !_ looks appropriate

@t6s t6s changed the title change the notation for tnth from \_ to \__ change the notation for tnth from \_ to avoid a conflict with mca Dec 8, 2023
@t6s
Copy link
Collaborator Author

t6s commented Dec 8, 2023

looks pretty enough

Copy link
Owner

@affeldt-aist affeldt-aist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good improvement.

@affeldt-aist affeldt-aist merged commit d6a61b4 into master Dec 8, 2023
4 checks passed
@t6s t6s deleted the tuple_notation branch December 8, 2023 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants