Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes non forgetful inheritance in Monad factories #143

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Fixes non forgetful inheritance in Monad factories #143

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions theories/core/category.v
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@
Example hom_compA' (a b c d : C) (h : {hom c, d}) (g : {hom b, c}) (f : {hom a, b}) :
(h \o g) \o f = [\o h, g, f].
Proof.
rewrite 10!compA.

Check warning on line 159 in theories/core/category.v

View workflow job for this annotation

GitHub Actions / build (mathcomp/mathcomp:2.2.0-coq-8.19) 

Command "Undo." is not recommended in batch mode. In particular,
Undo 1.
by rewrite !hom_compA.
(* rewrite !homcompA blocks id's from coming in, thanks to {hom _,_} conditions on arguments. *)
Expand Down Expand Up @@ -909,8 +909,7 @@
congr (fun f => bind f mmma).
by rewrite hom_ext.
Qed.
HB.instance Definition _ := isMonad.Build C F bindE joinretM joinMret joinA.
(* TODO: eliminate Warning: non forgetful inheritance detected *)
HB.instance Definition _ := isMonad.Build C M bindE joinretM joinMret joinA.
HB.end.

Module _Monad_of_adjoint_functors.
Expand Down Expand Up @@ -963,8 +962,8 @@
bind f m = join b (([the {functor C -> C} of M] # f) m).
Proof. by []. Qed.
HB.instance Definition monad_of_adjoint_mixin :=
isMonad.Build C M bindE join_left_unit join_right_unit join_associativity.
(* TODO: eliminate Warning: non forgetful inheritance detected *)
isMonad.Build C (M : _ -> _)
bindE join_left_unit join_right_unit join_associativity.
End def.
Definition build (C D : category)
(F : {functor C -> D}) (G : {functor D -> C}) (A : F -| G) :=
Expand Down
Loading