add 4th send return mode: Old Observable mode AND option auto connect code #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this mode will return a Observable and next it when send this mode useful when someone use flatMap function in Rxjs. option auto connect code
|
We need someone to test the code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.add 4th send return mode: Old Observable mode
this mode will return a Observable and next it when send
this mode useful when someone use flatMap function in Rxjs.
2.option auto connect code
use
mustReconnectCloseStatusCodeListandnotReconnectCloseStatusCodeListto config when to reconnect3.default close mode is
close(false)so, you can simple write
close()to close itI dont test the code. because my test evironment broken, this lib cannot create any connect, only by a reboot on my computer. (+_+)
now I lost my test evironment.
So, this PR need complete test before merge.