Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.NET api call example #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

.NET api call example #5

wants to merge 1 commit into from

Conversation

faabebe
Copy link

@faabebe faabebe commented Apr 3, 2020

No description provided.

faabebe
faabebe commented Apr 3, 2020
View reviewed changes
Copy link
Author

@faabebe faabebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

asdf

naodya
naodya reviewed Apr 4, 2020
View reviewed changes
Copy link
Contributor

@naodya naodya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not commit client id and client secret. Possibly add them to an env file and ignore them.

dotnet-cognito-auth/donet-api-gateway-auth/ApiHelper.cs
private static string GenerateOauthToken()
{
//TODO: pull this from env vars
string consumerKey = "5mulvgjjlbbm4cb8p7s1d6li8i";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Client id and secret should not be committed, please add them to environment variables

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naodya naodya naodya left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@faabebe @naodya