fix async

after-ephemera · Feb 26, 2024 · a03f0b7 · a03f0b7
1 parent e87dbac
commit a03f0b7
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 14 deletions.
diff --git a/src/api/oncall/index.ts b/src/api/oncall/index.ts
@@ -8,18 +8,22 @@ export const getOncallSlackMembers = async (): Promise<OncallSlackUser[]> => {
   const pdUsers: PdOncallResult[] = await pagerDuty.getOncalls(null);
   const slack = new SlackApi();
   for (const pdUser of pdUsers) {
-    const slackUser: Member = await slack.getUser(pdUser.user.email);
-    oncallSlackMembers.push(
-      new OncallSlackUser(
-        pdUser.user.name,
-        pdUser.user.email,
-        pdUser.user.id,
-        pdUser.schedule.id,
-        slackUser.id ?? ""
-      )
-    );
-    if (slackUser.name !== undefined) {
-      oncallSlackerNames.push(slackUser.name);
+    try {
+      const slackUser: Member = await slack.getUser(pdUser.user.email);
+      oncallSlackMembers.push(
+        new OncallSlackUser(
+          pdUser.user.name,
+          pdUser.user.email,
+          pdUser.user.id,
+          pdUser.schedule.id,
+          slackUser.id ?? ""
+        )
+      );
+      if (slackUser.name !== undefined) {
+        oncallSlackerNames.push(slackUser.name);
+      }
+    } catch (e) {
+      console.error(`Error getting slack user for ${pdUser.user.email}`);
     }
   }
   return oncallSlackMembers;

diff --git a/src/app.ts b/src/app.ts
@@ -16,7 +16,7 @@ const app = new App({
 registerListeners(app);
 
 /** Start Bolt App */
-await (async () => {
+(async () => {
   try {
     await app.start(process.env.PORT ?? 3000);
     console.log("⚡️ Bolt app is running! ⚡️");

diff --git a/tsconfig.json b/tsconfig.json
@@ -29,7 +29,7 @@
         /* Modules */
         "module": "NodeNext", /* Specify what module code is generated. */
         // "rootDir": "./",                                  /* Specify the root folder within your source files. */
-        "moduleResolution": "nodenext",                       /* Specify how TypeScript looks up a file from a given module specifier. */
+        "moduleResolution": "Nodenext",                       /* Specify how TypeScript looks up a file from a given module specifier. */
         "baseUrl": ".",                                  /* Specify the base directory to resolve non-relative module names. */
         "paths": {
           "@src*": ["./src", "src/*"],