handle when the oncall doesn't exist

after-ephemera · Mar 7, 2024 · a99870a · a99870a
1 parent 17e7706
commit a99870a
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/src/api/oncall/index.ts b/src/api/oncall/index.ts
@@ -19,7 +19,7 @@ export const getOncallSlackMembers = async (): Promise<OncallSlackUser[]> => {
           slackUser.id ?? ""
         )
       );
-      if (slackUser.name !== undefined) {
+      if (slackUser && slackUser.name !== undefined) {
         oncallSlackerNames.push(slackUser.name);
       }
     } catch (e) {

diff --git a/src/api/pd/ls.ts b/src/api/pd/ls.ts
@@ -38,7 +38,7 @@ export const makeOncallMappingMessage = (
       .map(
         ([shortnames, s]: Array<string[] | OncallSlackUser | undefined>) =>
           `(${(shortnames as string[]).join(" | ")}): @${
-            (s as OncallSlackUser).name
+            (s as OncallSlackUser)?.name
           }`
       )
       .join("\n")

diff --git a/src/listeners/events/app-mentioned.ts b/src/listeners/events/app-mentioned.ts
@@ -14,7 +14,7 @@ const appMentionedCallback = async ({
   event,
   say,
 }: AllMiddlewareArgs & SlackEventMiddlewareArgs<"app_mention">): Promise<void> => {
-  console.log("**** bot mentioned");
+  console.log(`**** bot mentioned ${event.text}`);
   const threadTs = event.ts;
   if (event.text.match(VERSION_REGEX) !== null) {
     await say({