Merge pull request #91 from afterpay/update-configuration-tests

Update set configuration tests with locale cases
afterpay · Oct 22, 2020 · 8c53720 · 8c53720
2 parents 6e18e8a + 1d38845
commit 8c53720
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 4 deletions.
diff --git a/afterpay/src/main/kotlin/com/afterpay/android/Afterpay.kt b/afterpay/src/main/kotlin/com/afterpay/android/Afterpay.kt
@@ -96,10 +96,8 @@ object Afterpay {
                     throw IllegalArgumentException("Minimum order amount is invalid")
                 }
             }
-
-            val validCountries = Locales.validSet.map { it.country }
-
-            if (!validCountries.contains(configuration.locale.country)) {
+            if (!Locales.validSet.contains(configuration.locale)) {
+                val validCountries = Locales.validSet.map { it.country }
                 throw IllegalArgumentException(
                     "Locale contains an unsupported country: ${configuration.locale.country}. " +
                         "Supported countries include: ${validCountries.joinToString(",")}"

diff --git a/afterpay/src/test/kotlin/com/afterpay/android/AfterpayTest.kt b/afterpay/src/test/kotlin/com/afterpay/android/AfterpayTest.kt
@@ -98,4 +98,16 @@ class AfterpayTest {
             )
         }
     }
+
+    @Test
+    fun `setConfiguration throws for a locale not in the valid set`() {
+        assertThrows(IllegalArgumentException::class.java) {
+            Afterpay.setConfiguration(
+                minimumAmount = "10.00",
+                maximumAmount = "100.00",
+                currencyCode = "AUD",
+                locale = Locale.JAPAN
+            )
+        }
+    }
 }