Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sample app to include Afterpay V2 example #246

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

tir38
Copy link
Collaborator

@tir38 tir38 commented Aug 27, 2024

We need to make a network request to the mock/local server. There were any number of ways to do this but I chose retofit/moshi because why not.

The rest of the flow in the sample activity should be pretty straight forward.

Copy link
Collaborator

@BrianGardnerAtl BrianGardnerAtl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Is there a reason to keep the commented out dependency in the gradle file?

@tir38
Copy link
Collaborator Author

tir38 commented Sep 19, 2024

Looks good to me. Is there a reason to keep the commented out dependency in the gradle file?

yeah it's so we/and other devs can easily switch back between what's in this repo versus what version we've pushed to maven. Its sort of a way to check that what ended up on maven is functional.

@tir38 tir38 force-pushed the jatwood/update-sample-app-to-include-v2 branch from 9bb0381 to 3a2c851 Compare September 19, 2024 18:19
@tir38 tir38 merged commit 9e0a126 into master Sep 19, 2024
3 checks passed
@tir38 tir38 deleted the jatwood/update-sample-app-to-include-v2 branch September 19, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants