-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation for V3 #248
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. The setup instructions were clear. Not sure if we'd want to more strongly recommend folks go with a V3 implementation so there's no server communication required
Confusingly the |
d6c75f7
to
3ae7392
Compare
{: .alert } | ||
> Checkout V3 is currently available in the following region(s): US, UK, Australia and Canada | ||
> | ||
Checkout V3 generates a one-time payment card for every Afterpay order and provides the card number to insert into your credit card checkout. This allows for a front-end-only integration. Unlike V1 and V2, with V3 your server does not directly interact with Afterpay APIs. The one-time payment card is Visa for the US, UK, and Canada. In Australia the one-time payment card is Mastercard. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is added to the alert section, I think we can leave it as plain text
@@ -1,11 +1,11 @@ | |||
--- | |||
layout: default | |||
title: Cash App Pay | |||
title: Checkout V2 with Cash App Pay |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On iOS this is just Cash App Pay
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to distinguish v2 and v3 each with cash app pay
layout: default | ||
title: Checkout V3 with Cash App Pay | ||
parent: Getting Started | ||
nav_order: 7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On iOS this is before Cash App Pay
docs/getting-started/checkout-v3.md
Outdated
} | ||
``` | ||
|
||
## Step 4: Receive one-time use card details and pass back to your server for processing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think you need to pass these back to your server, you can drop these into any checkout form
it.cardDetails | ||
it.tokens | ||
it.cardValidUntil | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the SDK supports updateMerchantReferenceV3
we should add an entry
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll add this to my TODO
nav_order: 5 | ||
--- | ||
|
||
# Checkout V3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
iOS has a Sequence Diagram, you can probably use the same one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed it on purpose. I think is not accurate and a bit confusing.
} | ||
``` | ||
|
||
## Step 11: Receive one-time use card details and pass back to your server for processing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need to send details back to server
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
they need to do something with those card details right?
``` kotlin | ||
cashAppPay.unregisterFromStateUpdates() | ||
``` | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can include the sequence diagram here
3ae7392
to
adc206f
Compare
adc206f
to
94baa97
Compare
This is documentation for V3 and V3 for Cash App Pay.