-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge feature/button to master #272
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is required for the V3/Button functionality
This is required now that the Afterpay SDK is interacting directly with the API rather than through a merchant API
Previously, this object was retrieved via the merchant’s API. Now, we add an option to fetch it directly for V3 use
This is handy for cases where the response body is 204/empty but valid
…to-feature-button Maintenance/merge master 5.6.1 to feature button
Button with Cash App Pay
mmroz
commented
Jun 13, 2024
mmroz
force-pushed
the
markmroz/feature-button-master
branch
from
June 17, 2024 16:58
cbb05eb
to
f5071e9
Compare
mmroz
force-pushed
the
markmroz/feature-button-master
branch
from
June 17, 2024 23:12
37a0f13
to
25714c3
Compare
mmroz
changed the title
Merge feature/button in to master
Merge feature/button to master
Jun 17, 2024
* master: docs: add checkout diagrams
ScottAntonacAP
approved these changes
Jun 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. 👏
Also tested locally and all checkout methods work
✅ V1
✅ V2
✅ V2 with CAP
✅ V3
✅ V3 with CAP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges the feature/button branch in to master.
I updated the demo app to showcase V1, V2 and button more clearly. There is now an edit button to select the preferred checkout method.
Simulator.Screen.Recording.-.12.-.2024-06-17.at.19.21.54.mp4