Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge feature/button to master #272

Merged
merged 112 commits into from
Jun 18, 2024
Merged

Merge feature/button to master #272

merged 112 commits into from
Jun 18, 2024

Conversation

mmroz
Copy link
Collaborator

@mmroz mmroz commented Jun 11, 2024

This PR merges the feature/button branch in to master.

I updated the demo app to showcase V1, V2 and button more clearly. There is now an edit button to select the preferred checkout method.

Simulator.Screen.Recording.-.12.-.2024-06-17.at.19.21.54.mp4

nesevis added 30 commits July 8, 2021 14:47
This is required for the V3/Button functionality
This is required now that the Afterpay SDK is interacting directly with the API rather than through a merchant API
Previously, this object was retrieved via the merchant’s API. Now, we add an option to fetch it directly for V3 use
This is handy for cases where the response body is 204/empty but valid
@mmroz mmroz force-pushed the markmroz/feature-button-master branch from cbb05eb to f5071e9 Compare June 17, 2024 16:58
@mmroz mmroz force-pushed the markmroz/feature-button-master branch from 37a0f13 to 25714c3 Compare June 17, 2024 23:12
@mmroz mmroz changed the title Merge feature/button in to master Merge feature/button to master Jun 17, 2024
@mmroz mmroz marked this pull request as ready for review June 17, 2024 23:40
@mmroz mmroz requested a review from benfterpay as a code owner June 17, 2024 23:40
Copy link
Collaborator

@ScottAntonacAP ScottAntonacAP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. 👏
Also tested locally and all checkout methods work

✅ V1
✅ V2
✅ V2 with CAP
✅ V3
✅ V3 with CAP

@mmroz mmroz merged commit 650a0a7 into master Jun 18, 2024
4 checks passed
@mmroz mmroz deleted the markmroz/feature-button-master branch June 18, 2024 17:32
@ScottAntonacAP ScottAntonacAP added the enhancement New feature or request label Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants