Add Feature - BSX Loading #89
Conversation
|
I thank you for splitting up the commits, but I would really like the GSU commit to be a part of a separate PR. The problem with you closing a PR like that and reopening, is now all of the comments and history have been lost, so I have to re-review everything. For future reference, you could have force pushed to the branch, overwriting your previous commits, and Github would have kept history of what happened. In your closing comment, you stated that MiSTer detects BSX using it's |
|
Very Sorry about that , thats the reason i hate making/ammending PR's , i find github hard to navigate and not sure where everything is haha. I did try sending both commits as seperate pull requests , but it seemed to have merged them again. ill have a read up on what you wrote. im back in the land of discovery so looking at it all again lol |
There was a problem hiding this comment.
Only added BSX bios check. To run bsx roms on pocket the end user has to concatenate the bs rom on top of the BSX bios and edit the header of the bs rom if its needed. Im in the process of making a script to do this.
MiSTer uses the filename extension "bs" to detect when a bs rom is loaded and im not sure that is do-able on pocket plus even if it were possible you would then need to load the BSX bios at offset 0x10000000 and swap the bs rom to 0x10100000 which i have not been able to make happen.
There was a problem hiding this comment.
managed to add .BS extension detection and auto load data slot 1 bsx bios into address 0x10000000 once a .bs rom is loaded. Works quite well now haha , Code probably looks a bit of a mess lol.....I think the only thing wrong now is it doesnt want to save any data for BSX roms or the bios which can get annoying keep having to input your name.
There was a problem hiding this comment.
How big is the BSX BIOS? I would prefer to not load it every time and slow down ROM loading for everyone else. However, that would mean we'd have to use the file read API, which may not be easy.
There was a problem hiding this comment.
it is 1MB and doesnt it only load the bios when a .bs is loaded
There was a problem hiding this comment.
Oh, this is selectively loading the BIOS, isn't it? It checks the ROM extension, and if so loads the BIOS, then the ROM at the offset you specified?
There was a problem hiding this comment.
yes thats how it should be working if its correct , it checks for the .bs extension when a file is loaded then if it matches, loads the bios and sets the core, then loads the bios @ 0x10000000 and then loads the inital .bs rom at 0x10100000
Fixes saving
|
@terminator2k2 What is the status on this PR? Did you get everything working? |
yes , should be good to go, i also made a patcher here : https://github.com/terminator2k2/BSX-Rom-Patcher for bsx roms as some games were time limited and were only playable on certain days/weeks of release. some info here : https://wiki.superfamicom.org/bs-x-satellaview-header |
Changed warning text style
Fixes for : Rendering Ranger - SMP: fix IO timings for accuracy Kawasaki Superbike Challenge - SCPU: fix the reset timings
65816: -fix instructions in emulation mode (gilyon's test) -fix interrupt timings SPC700: fix DIV instrution (gilyon's test) PPU: -adjust the HBLANK start position -adjust the M7 registers latch time S-CPU: some rework to improve accuracy SA1: rework clock synchronization 65C816: fix IRQ interrupt SA1: -fix open bus -implement RAM write protection (partial)
SA1: fixes for write protection.
|
@terminator2k2 Can you please do a PR to @agg23 fork with only the upstream fixes and another with the BSX-related patches? |
bsx roms dont need concatenating, when you load a .bsx file it automatically loads the bsx bios. I done a PR some time ago. |
Can you please point me to the commit that fixed that? |
it was done in the chip32 rom loader |
No description provided.