feat: prometheus #201
Merged
feat: prometheus #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ToniRamirezM
requested review from
joanestebanr,
vcastellm and
arnaubennassar
vcastellm
reviewed
Feb 17, 2025
| @@ -0,0 +1,677 @@ | |||
| package prometheus | |||
There was a problem hiding this comment.
From where is this code comming from? Do we need all of this functionalities?
There was a problem hiding this comment.
It comes from the metric package in zkevm-node. We just need counters now, but if in the future we need any other kind of metric, it will be already there ready to be used.
|
goran-ethernal
approved these changes
Feb 24, 2025
joanestebanr
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds prometheus metrics endpoint.
Closes #195
Related PR on Kurtosis repo:
0xPolygon/kurtosis-cdk#476