Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAXIMUM_LOG2M_PARAM inconsistent with storage specification and postgresql-hll #14

Open
hossman opened this issue May 2, 2015 · 0 comments

Comments

@hossman
Copy link

hossman commented May 2, 2015

The storage specification, and postgress-hll docs each say...

https://github.com/aggregateknowledge/hll-storage-spec/blob/v1.0.0/STORAGE.md

registerWidth may take values from 1 to 8, inclusive, and log2(numberOfRegisters) may take on 4 to 31, inclusive.

https://github.com/aggregateknowledge/postgresql-hll/blob/master/README.markdown#explanation-of-parameters-and-tuning

The log-base-2 of the number of registers used in the HyperLogLog algorithm. Must be at least 4 and at most 31.

However in the javacode itself...

public static final int MAXIMUM_LOG2M_PARAM = 30;

From what i can see this means postgresql-hll can produce a serialized HLL which can not be parsed by HLL.fromBytes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant