Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update orb version and pass the spec #112

Merged
merged 2 commits into from
Oct 29, 2024
Merged

Update orb version and pass the spec #112

merged 2 commits into from
Oct 29, 2024

Conversation

naopontan
Copy link

@naopontan naopontan commented Oct 29, 2024 •
edited
Loading

@naopontan naopontan marked this pull request as ready for review October 29, 2024 07:47
zh
zh approved these changes Oct 29, 2024
View reviewed changes
Copy link

@zh zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: remove pending and make tests really pass.

@zh zh merged commit 4dbb955 into master Oct 29, 2024
4 checks passed
@zh zh deleted the update-orb-and-pass-spec branch October 29, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zh zh zh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@naopontan @zh